Hi all, I am working on a issue in the `Warnings-ng-plugin` related to duplicate warning tabs being shown when a build fails before the warnings tool executes, after a previous successful build.
There is a proper integration test which expose the bug correctly. However, while implementing the fix, it is not clear to me what the intended responsibility of `TransientActionFactory` is this scenario: - Is `TransientActionFactory` expected to ensure `JobActions` are only attached once per tool? - Should it be responsible for de-duplication when builds fail before publishers execute? - Or should this logic live elsewhere (e.g. in `MissingResultFallbackHandler` or `JobAction` itself or any other place)? Issue link: https://github.com/jenkinsci/warnings-ng-plugin/issues/3181 Pull Request link: https://github.com/jenkinsci/warnings-ng-plugin/pull/3234 Thank you, Akash Manna -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/jenkinsci-dev/dc586871-3784-4108-b9f8-952e41bba373n%40googlegroups.com.
