[
https://issues.jenkins-ci.org/browse/JENKINS-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=158714#comment-158714
]
Joshua Niehus edited comment on JENKINS-11969 at 2/7/12 5:58 AM:
-----------------------------------------------------------------
This issue should be resolved by my pull request and its subsequent commits on
GitHub:
https://github.com/jenkinsci/token-macro-plugin/pull/4
Fixing commit:
https://github.com/jniehus/token-macro-plugin/commit/a1c32a353ea964ca9de2891524a6005a2a4da3e3
was (Author: joshua_niehus):
This issue should be resolved by my Pull request and its subsequent
requests on GitHub:
https://github.com/jenkinsci/token-macro-plugin/pull/4
Fixing commit:
https://github.com/jniehus/token-macro-plugin/commit/a1c32a353ea964ca9de2891524a6005a2a4da3e3
> PROPFILE token does not properly close the property file
> --------------------------------------------------------
>
> Key: JENKINS-11969
> URL: https://issues.jenkins-ci.org/browse/JENKINS-11969
> Project: Jenkins
> Issue Type: Bug
> Components: token-macro
> Affects Versions: current
> Environment: Jenkins 1.441
> token-macro-plugin 1.5.1
> Windows 7 x64 build slave running Sun JDK 1.6.0_20-b02
> Reporter: rvaughn
> Assignee: Kohsuke Kawaguchi
> Labels: macro, plugin, propfile, token, token-macro
>
> The current implementation of the PROPFILE token does not explicitly close
> the property file after reading it. This can lead to the property file being
> held open by the JVM for extended periods, long beyond the duration of the
> build job. On my Windows 7 build slave, the file appears to be held open
> indefinitely, and while testing the bug I once even saw two separate file
> handles open against a single property file. The open file handles prevent
> the file from being manipulated (deleted, moved, etc.) in Windows.
> PropertyFromFileMacro.ReadProperty.call() should explicitly close the input
> file immediately after calling Properties.load().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
