[ 
https://issues.jenkins-ci.org/browse/JENKINS-7219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159049#comment-159049
 ] 

SCM/JIRA link daemon commented on JENKINS-7219:
-----------------------------------------------

Code changed in jenkins
User: Francis Upton IV
Path:
 src/main/java/hudson/plugins/ec2/ssh/EC2UnixLauncher.java
http://jenkins-ci.org/commit/ec2-plugin/98309095065189ad51033e80f5dea694ce2d9331
Log:
  [FIXED JENKINS-7219] EC2 slaves fail to launch when using old (< 1.9) configs





                
> EC2 slaves fail to from older configs prior to having the jvmopts
> -----------------------------------------------------------------
>
>                 Key: JENKINS-7219
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-7219
>             Project: Jenkins
>          Issue Type: Bug
>          Components: ec2
>            Reporter: mjmac
>            Assignee: francis Upton
>
> After upgrading the plugin from 1.8 -> 1.9, I could no longer launch EC2 
> slaves.  A log excerpt would show something like the following:
> ...
> Verifying that java exists
> java full version "1.6.0_15-b03"
> Copying slave.jar
> Launching slave agent
> ...
> Then an IOException about the channel being closed unexpectedly (sorry, 
> didn't capture the trace).  Eventually the launch would time out and it would 
> try again and again with no success.
> After looking at the svn log I noticed the following change (r33881), which 
> seemed to be where it was dying:
> -            sess.execCommand("java -jar /tmp/slave.jar");
> +            sess.execCommand("java " + computer.getNode().jvmopts + " -jar 
> /tmp/slave.jar");
> It occurred to me that maybe the jvmopts value didn't exist in the 1.8-style 
> EC2 config, so I saved the AMI with "-verbose" in the JVM options field, 
> saved the config, and launched an EC2 slave successfully.  I killed that 
> slave, blanked out the JVM options field, saved again, and again successfully 
> launched an EC2 slave.
> Maybe the plugin needs to guard against a null value from older configs or 
> else massage old configs to fit into the new "schema" or something?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to