[
https://issues.jenkins-ci.org/browse/JENKINS-12755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159070#comment-159070
]
dogfood commented on JENKINS-12755:
-----------------------------------
Integrated in !http://ci.jenkins-ci.org/images/16x16/blue.png!
[plugins_perforce #177|http://ci.jenkins-ci.org/job/plugins_perforce/177/]
[FIXED JENKINS-12755] committing Andy Tang's patch to add counter name
substitution (Revision 1617ca1b0b98fa3ec33f22f29fb0d04b4e82af9e)
Result = SUCCESS
Rob Petti :
Files :
* src/main/java/hudson/plugins/perforce/PerforceSCM.java
> P4 Counter text field does not do env variable subsitution
> ----------------------------------------------------------
>
> Key: JENKINS-12755
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12755
> Project: Jenkins
> Issue Type: Bug
> Components: perforce
> Affects Versions: current
> Environment: RH 6
> Reporter: Andy Tang
> Priority: Minor
> Attachments: PerforceSCM.java
>
>
> Currently the P4 counter text field does not expand env variables when run.
> Steps to reproduce:
> 1) Setup a build job
> 2) Enable Perforce plugin
> 3) In the P4 Counter text field, enter a counter name with env varaible,
> example: counter_${JOB_NAME}
> 4) Start the build
> Result:
> The perforce plugin saves the synced chagnelist to counter_${JOB_NAME}
> instead of substituting it when creating a counter name. Env substitution
> would be useful in here as I can set this once and use it in different jobs.
> I have actually re-compiled the latest 1.3.8-snapshot with changes to support
> env variables substitution. It was a one line change...what would be best
> method to publish my work? (Sorry this is my first time contributing :)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira