[ 
https://issues.jenkins-ci.org/browse/JENKINS-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=160262#comment-160262
 ] 

Roland Schulz commented on JENKINS-13056:
-----------------------------------------

I agree that the issue isn't specific to static analysis. 

I think any SCM history which is not linear would benefit from it. The non 
linear history could be branches, changeset, etc. E.g. if versions B and C are 
compiled after each other, and they both have A as ancestor, then it is not 
correct if C is using B as reference build. E.g. if B has introduced a few 
warnings, than build C would report those warnings as fixed. But they are not 
fixed because these warning still exist in the separate branch/changeset. 

If the threshold is set so that the count for B is above the limit, then 
relaying on the threshold works correctly. But in the general case it would not 
give the correct result. Also using the threshold makes it so that a build for 
version D with ancestor B doesn't report the warnings as fixed.

Also it seems (but I'm highly uncertain so please correct me if I'm wrong), 
that also unstable builds are considered for the reference build (and only 
failed ones are excluded). Thus it is not enough to set the status threshold 
(either new or total) for unstable but one has to set it for failed if one 
wants to affect the reference build. Also I assume that only the status 
threshold and not the health threshold effect the reference build. 
                
> Obtain reference build from SCM/Trigger
> ---------------------------------------
>
>                 Key: JENKINS-13056
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13056
>             Project: Jenkins
>          Issue Type: Bug
>          Components: analysis-core, core, warnings
>            Reporter: Roland Schulz
>            Assignee: Ulli Hafner
>
> It would be great if the SCM would be queried for the reference build. If the 
> builds are not in order (e.g. because the build are triggered by code review 
> (e.g. Gerrit)), it doesn't make sense to use the last build as reference. The 
> SCM (e.g. Git) or the Trigger (e.g. Gerrit) would know the previous commit 
> which should be used as reference. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to