[
https://issues.jenkins-ci.org/browse/JENKINS-13324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=161176#comment-161176
]
Rob Petti commented on JENKINS-13324:
-------------------------------------
PerforceMailResolver will return null if no email address is found. The problem
as you said is that perforce will always have an email set for users, and will
invent an email address if none is supplied (usually user@host or user@client).
I don't really have a problem with hard coding some value such as 'n/a',
assuming that perforce will accept it as a valid email address. Though I
question the need for it, since perforce admins will need to forcefully reset
all the email addresses to that value anyways. If someone needs to go through
all that trouble to set email addresses to 'n/a', why not just set the email
addresses correctly instead?
> Perforce mail address resolver should fall back to other resolvers if mail
> address is invalid
> ---------------------------------------------------------------------------------------------
>
> Key: JENKINS-13324
> URL: https://issues.jenkins-ci.org/browse/JENKINS-13324
> Project: Jenkins
> Issue Type: Bug
> Components: perforce
> Environment: Perforce 2011.1
> perforce-plugin 1.3.12
> Reporter: Mikko Tapaninen
>
> Perforce mail address resolver is always returning a string, no matter what
> the actual email address is. I don't know what is the order how Jenkins loops
> through the various MailAddressResolver instances but if some instance
> returns an actual string (i.e. non-null), it will stick with that. I don't
> think it's feasible to really check whether the email address provided by
> Perforce is valid, but PerforceMailResolver could check for some value (e.g.
> "n/a") and return null if it matches. At least with Perforce 2011.1 you can't
> have an empty value for an email address.
> There could be an UI element for configuring which email address would be
> thought as invalid, but I'm fine with hardcoding "n/a" there and documenting
> it somewhere. Would this be ok?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
