[
https://issues.jenkins-ci.org/browse/JENKINS-13591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162026#comment-162026
]
jieryn commented on JENKINS-13591:
----------------------------------
I looked at your changes, but I think this will break when the user is not on
the main page. Did you test this when inside a specific build's console output,
e.g.?
Once you confirm that this is fixed for all types of URLs, not just with and
without a /jenkins context (e.g. behind a proxy) and for all types of pages the
user could be on, send a pull request and we'll incorporate it!
Your code looks good otherwise.. :-)
> Plugin doesn't support jenkins URL prefix (--prefix option)
> -----------------------------------------------------------
>
> Key: JENKINS-13591
> URL: https://issues.jenkins-ci.org/browse/JENKINS-13591
> Project: Jenkins
> Issue Type: Bug
> Components: html5-notifier
> Affects Versions: current
> Reporter: Ludovic Meurillon
> Assignee: jieryn
>
> My jenkins is running behind an apache server, my configuration is very
> simple and look like this one :
> https://wiki.jenkins-ci.org/display/JENKINS/Running+Jenkins+behind+Apache
> The plugin doesn't work with this configuration because absolute URL are used
> into the javascript code, for example in html5-notification.js there is a
> ...new Ajax.Request('/html5-notifier-plugin/list')...
> that refer in my case to http://<HOST>/html5-notifier-plugin/list, but the
> real list is at http://<HOST>/jenkins/html5-notifier-plugin/list
> It might be a Jenkins way to get the server URL properly and inject it into
> js files or java generated js code.
> Ludovic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
