[ 
https://issues.jenkins-ci.org/browse/JENKINS-13618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162122#comment-162122
 ] 

cjo9900 commented on JENKINS-13618:
-----------------------------------

After some tracing of the form submission, I can see that correct data is sent 
to the objects.
However the pre-scm-plugin relies on teh build steps to have a relevant 
DataBoundConstructor, however the conditionbuilder does not have the correct 
one and only has the first two parameters in the constructor. 

https://github.com/jenkinsci/conditional-buildstep-plugin/blob/master/src/main/java/org/jenkinsci/plugins/conditionalbuildstep/ConditionalBuilder.java

Fix is either
1. Only allow buildsteps with a databoundconstructor(same as is done in 
conditionalbuildstep) 
2. Correct the conditionalbuildstep DataboundConstructor.

1 in this case would not solve the issue as the DataboundConstructor is 
incorrect.
so we need to correct the conditionalbuildstep plugin.


I have done a quick hack and proved that correcting the conditionalbuildstep 
DataboundConstructor solves the issue.
I now need some time to clean this up and run some more testing on it.



                
> preSCMbuildstep plugin - Unable to use multiple Conditional Steps in the 
> Prebuild section of Multi configuration job
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: JENKINS-13618
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-13618
>             Project: Jenkins
>          Issue Type: Bug
>          Components: conditional-buildstep, prescmbuildstep
>         Environment: Win7
>            Reporter: Dawg Gone
>            Assignee: cjo9900
>              Labels: DataBoundConstructor, plugins
>
> 1.) Add a "Conditional steps (multiple)" item to the Prebuild section of a 
> multiple configuration job.
> 2.) Use "Strings Match" as the type (don't think this matters).
> 3.) "Add step to condition".  Select one or more steps to put under this 
> condition.
> 4.) Click "Save" button and exit the job.
> 5.) Re-"Configure" the Job.  The steps added under the multi-conditional step 
> are now gone.  No matter what I do, I am unable to add steps under the 
> multiple conditional step.
>  Note: I am able to add multi-conditional steps to my project in the normal 
> "build" location.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to