[
https://issues.jenkins-ci.org/browse/JENKINS-13589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=162280#comment-162280
]
SCM/JIRA link daemon commented on JENKINS-13589:
------------------------------------------------
Code changed in jenkins
User: Gregory Boissinot
Path:
src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java
http://jenkins-ci.org/commit/cppcheck-plugin/2c22881a62bd4bd4fa8797cdc7cd8d2afc92f868
Log:
Fix JENKINS-13589
> Erroneous calculation of threshold crossing
> -------------------------------------------
>
> Key: JENKINS-13589
> URL: https://issues.jenkins-ci.org/browse/JENKINS-13589
> Project: Jenkins
> Issue Type: Bug
> Components: cppcheck
> Affects Versions: current
> Reporter: Alexandr Penzai
> Assignee: gbois
> Priority: Minor
>
> There is a typo in
> https://github.com/jenkinsci/cppcheck-plugin/blob/master/src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java#L211
> as result plugin incorrectly calculates total amount of errors
> {noformat}
> - nbErrors = this.getReport().getWarningSeverityList().size();
> + nbErrors = nbErrors + this.getReport().getWarningSeverityList().size();
> {noformat}
> and for previous errors
> https://github.com/jenkinsci/cppcheck-plugin/blob/master/src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java#L213
> {noformat}
> - nbPreviousError =
> previousResult.getReport().getWarningSeverityList().size();
> + nbPreviousError = nbPreviousError +
> previousResult.getReport().getWarningSeverityList().size();
> {noformat}
> Please correct.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira