[
https://issues.jenkins-ci.org/browse/JENKINS-13927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=163465#comment-163465
]
Lance Wicks commented on JENKINS-13927:
---------------------------------------
Do you think it is this block of code in TapResult.java:
private boolean isFailure(TestResult testResult) {
boolean r = false;
Directive directive = testResult.getDirective();
StatusValues status = testResult.getStatus();
if (directive != null
&& directive.getDirectiveValue() == DirectiveValues.TODO) {
r = true;
} else if (status != null && status == StatusValues.NOT_OK) {
r = true;
}
return r;
}
Do you think the else if should return r = false; ?
I don't write Java so just guessing.
:-)
> TAP: Failed test does not set build to failed.
> ----------------------------------------------
>
> Key: JENKINS-13927
> URL: https://issues.jenkins-ci.org/browse/JENKINS-13927
> Project: Jenkins
> Issue Type: Bug
> Components: tap
> Environment: Jenkins ver. 1.461
> Jenkins TAP Plugin 1.2.8
> Reporter: Lance Wicks
> Assignee: Bruno P. Kinoshita
> Labels: plugin
> Attachments: TAP_BUG.png
>
>
> When the "Failed tests mark build as failure" option is activated on a job
> that runs on a jenkins slave, the TAP display shows a failed test
> The Jenkins build itself still shows as a success however.
> See attached screenshot. Notice TAP chart shows failures, but build history
> shows successful builds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
