[JIRA] [workflow-plugin] (JENKINS-29611) Snippetizer does not call overriden newInstance

[amu...@cloudbees.com (JIRA)]

Title: Message Title

Antonio Muñiz created an issue   Jenkins / JENKINS-29611 Snippetizer does not call overriden newInstance Issue Type: Bug Assignee: Jesse Glick Components: workflow-plugin Created: 24/Jul/15 11:34 AM Priority: Major Reporter: Antonio Muñiz If a plugin descriptor overrides Descriptor.newInstance(StaplerRequest, JSONObject) for some reason (usually preprocessing JSONObject), the overriden method is not called by Workflow Snippetizer. I think the reason is that Snippetizer is instantiating the wrong class. This is an example of JSON coming from the browser (on snippet generation click): { "stapler-class": "org.jenkinsci.plugins.workflow.steps.CoreStep", "": "0", "delegate": { "stapler-class": "hudson.plugins.findbugs.FindBugsPublisher", "pattern": "", "isRankActivated": false, "includePattern": "", "excludePattern": "", "canRunOnFailed": false, "shouldDetectModules": false, "healthy": "", "unHealthy": "", "thresholdLimit": "low", "unstableTotalAll": "", "unstableTotalHigh": "", "unstableTotalNormal": "", "unstableTotalLow": "", "failedTotalAll": "", "failedTotalHigh": "", "failedTotalNormal": "", "failedTotalLow": "", "canComputeNew": { "unstableNewAll": "10", "unstableNewHigh": "", "unstableNewNormal": "", "unstableNewLow": "", "failedNewAll": "", "failedNewHigh": "", "failedNewNormal": "", "failedNewLow": "", "useDeltaValues": true, "usePreviousBuildAsReference": false, "useStableBuildAsReference": false }, "defaultEncoding": "" } } From Snippetizer.java: Class<?> c = j.getPluginManager().uberClassLoader.loadClass(jsonO.getString("stapler-class")); Descriptor<?> descriptor = j.getDescriptor(c.asSubclass(Step.class)); The loaded class is org.jenkinsci.plugins.workflow.steps.CoreStep but it should be hudson.plugins.findbugs.FindBugsPublisher. In other words, the delegate field in the JSON object is being ignored. Add Comment   This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.