[JIRA] [gerrit-trigger-plugin] (JENKINS-31873) Connection Listener and Event Listener can miss connectionEstablished event

[eng...@gmail.com (JIRA)]

Title: Message Title

Jiří Engelthaler created an issue   Jenkins / JENKINS-31873 Connection Listener and Event Listener can miss connectionEstablished event Issue Type: Bug Assignee: rsandell Components: gerrit-trigger-plugin Created: 03/Dec/15 11:56 AM Priority: Major Reporter: Jiří Engelthaler Adding a new Connection Listener or Event Listener to already connected Gerrit server will not receive connectionEstablished event. addListener in gerrit-events library (https://github.com/sonyxperiadev/gerrit-events.git) will not trigger connectionEstablished if connection is already established. See GerritServer.java:517 This can be fixed here in this plugin but with risk of calling connectionEstablished twice gerritConnection.addListener(projectListUpdater); if (isConnected()) { projectListUpdater.connectionEstablished(); } 1) adding listener to not connected server 2) server is connected -> calling connectionEstablished 3) testing that server is connected -> calling connectionEstablished second time Maybe the best way is to change the code of addListener in gerrit-events library. Correct me if my thoughts are wrong. My knowledge of Java and Java internals are poor to fix it myself. Add Comment   This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.