[JIRA] [matrix-project-plugin] (JENKINS-33230) Jenkins creates lots of warning message for creating matrix project root directory

[k...@fortinet.com (JIRA)]

Title: Message Title

Kevin Yu created an issue   Jenkins / JENKINS-33230 Jenkins creates lots of warning message for creating matrix project root directory Issue Type: Improvement Assignee: Kohsuke Kawaguchi Components: matrix-project-plugin Created: 01/Mar/16 1:36 AM Environment: Jenkins 1.6.42.1 Ubuntu 14.04 JAVA 7 Priority: Minor Reporter: Kevin Yu Jenkins creates lots of warning message for matrix project. The size of log would just keep growing which makes it very hard to read. The log looks something like this: Feb 29, 2016 5:06:34 PM hudson.matrix.MatrixProject getRootDirFor WARNING: Cannot create directory /var/lib/jenkins/jobs/FortiAP-S/configurations/axis-BUILD_TYPE/release/axis-MODEL_NAME/FAP_S313C for the combination BUILD_TYPE=release,MODEL_NAME=FAP_S313C Feb 29, 2016 5:06:34 PM hudson.matrix.MatrixProject getRootDirFor WARNING: Cannot create directory /var/lib/jenkins/jobs/FortiAP-S/configurations/axis-BUILD_TYPE/release/axis-MODEL_NAME/FAP_S313C for the combination BUILD_TYPE=release,MODEL_NAME=FAP_S313C Feb 29, 2016 5:06:34 PM hudson.matrix.MatrixProject getRootDirFor After some debugging, I think the problem is that it's calling File.mkdirs(), which would return false if the folder already exist. public File getRootDirFor(@Nonnull Combination combination) { File f = getConfigurationsDir(); for (Entry<String, String> e : combination.entrySet()) f = new File(f,"axis-"+e.getKey()+'/'+Util.rawEncode(e.getValue())); if (!f.getParentFile().mkdirs()) { LOGGER.log(Level.WARNING, "Cannot create directory {0} for the combination {1}", new Object[]{f, combination}); } return f; } I suggest there should be a check whether the folder exist. if !f.exists() && !f.getParentFile().mkdirs(), then output the warning. Add Comment   This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.