[JIRA] (JENKINS-37189) a file:// update center will always be offline

[jn...@cloudbees.com (JIRA)]

Title: Message Title

James Nord created an issue   Jenkins / JENKINS-37189 a file:// update center will always be offline Issue Type: Bug Assignee: Unassigned Components: core Created: 2016/Aug/04 8:20 PM Environment: windows Priority: Major Reporter: James Nord The code in hudson.model.UpdateCenter$UpdateCenterConfiguration.checkUpdateCentermakes blind assumptions about the protocol and validity of an update center URL. Blindly appending a string to a URL does not necessarily a valid URL for connection checking make. For example the URL could be a file based url and the URL file://c:/some/path/to/updates.json will become file://c:/some/path/to/updates.json?uctest Later on the URL is used in hudson.model.UpdateCenter.UpdateCenterConfiguration.test connection(URL) - and if it is not a http URL it will try Util.copyStreamAndClose(connection.getInputStream(),new NullOutputStream()); which on windows will fail as it will try and open c:\some\path\to\updates.json?uctest which will fail with an exception - and then fail the update check. public void checkUpdateCenter(ConnectionCheckJob job, String updateCenterUrl) throws IOException { testConnection(new URL(updateCenterUrl + "?uctest")); } Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.