[JIRA] (JENKINS-38224) The html select element added by the dropdownlist.jelly form control needs to have a name attribute

[sridevi.sanga...@gmail.com (JIRA)]

Title: Message Title

Sridevi Sangaiah commented on JENKINS-38224   Re: The html select element added by the dropdownlist.jelly form control needs to have a name attribute I realized that when creating this enhancement I mentioned Id attribute instead of name attribute. Fixed it now. Sorry for the confusion. Explaining the requested enhancement with more details, below. Copying below a snippet from https://github.com/jenkinsci/ui-samples-plugin/blob/master/src/main/resources/jenkins/plugins/ui_samples/DropdownList/index.jelly <f:dropdownList name="fruit" title="Fruits"> <!-- Loop through available fruit types --> <j:forEach var="descriptor" items="${it.fruitDescriptors}" varStatus="loop"> <!-- Set "fruit" only if it matches this descriptor --> <j:set var="fruit" value="${descriptor==currentFruit.descriptor?currentFruit:null}"/> <f:dropdownListBlock title="${descriptor.displayName}" value="${loop.index}" selected="${fruit!=null}" staplerClass="${descriptor.clazz.name}"> <!-- Include config.jelly for this fruit type --> <st:include page="${descriptor.configPage}" from="${descriptor}"/> </f:dropdownListBlock> </j:forEach> </f:dropdownList> This jelly, after processing, will be converted to the following html structure. <tr> <td class="setting-leftspace">&nbsp;</td> <td class="setting-name">Fruits</td> <td class="setting-main"> <select class="setting-input dropdownList"> <option value="0">Apple</option> <option value="1">Banana</option> </select> </td> <td class="setting-no-help"></td> </tr> <tr class="dropdownList-container"> <td colspan="2"></td> <td colspan="2"> <table width="100%" name="fruit"> <tbody> <tr class="dropdownList-start rowvg-start"></tr> <!--Here goes the html when Apple is selected--> <tr class="dropdownList-end rowvg-end"></tr> <tr class="dropdownList-start rowvg-start" style="display: none;" field-disabled="true"></tr> <!--Here goes the html when Banana is selected--> <tr class="dropdownList-end rowvg-end"></tr> </tbody> </table> </td> </tr> Notice that the name specified on the dropdownList jelly tag is set as the name for the table control that contains the html block for the current dropdown selection. The select element doesn't have any identifier. This is not a problem when doing a submit/save as the html controls are parsed and the data is formatted to json before it is sent to the server. From the formatted data it will be possible to identify the current selection in the dropdown. But in case of validation, say I have to validate some behavior depending on the current selection in the dropdown, there is no way to get the current selection as the select element doesn't have a name attribute. https://wiki.jenkins-ci.org/display/JENKINS/Jelly+form+controls - clearly states that there should be a name associated with the input control, for it to be sent to the server for validation. I believe this is because validate uses the html form submit to pass data to the server, which would in turn do a lookup of html controls with the specified name. Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.