[JIRA] (JENKINS-23784) Allow parallel class loading

[jgl...@cloudbees.com (JIRA)]

Title: Message Title

Jesse Glick commented on JENKINS-23784   Re: Allow parallel class loading A related issue I just found while looking at a thread dump from an unresponsive instance: some threads such as at hudson.util.MaskingClassLoader.getResource(MaskingClassLoader.java:80) - waiting to lock <…> (a hudson.util.MaskingClassLoader) at java.lang.ClassLoader.getResource(ClassLoader.java:1091) at jenkins.util.AntClassLoader.getResource(AntClassLoader.java:888) at org.kohsuke.stapler.ClassDescriptor$ASM.loadParametersFromAsm(ClassDescriptor.java:258) at org.kohsuke.stapler.ClassDescriptor$ASM.access$100(ClassDescriptor.java:212) at org.kohsuke.stapler.ClassDescriptor.loadParameterNames(ClassDescriptor.java:145) at org.kohsuke.stapler.ClassDescriptor.loadConstructorParamNames(ClassDescriptor.java:179) at org.jenkinsci.plugins.workflow.cps.DSL.loadSoleArgumentKey(DSL.java:220) at org.jenkinsci.plugins.workflow.cps.DSL.parseArgs(DSL.java:356) at org.jenkinsci.plugins.workflow.cps.DSL.invokeStep(DSL.java:152) at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:124) at org.jenkinsci.plugins.workflow.cps.CpsScript.invokeMethod(CpsScript.java:117) at … or at hudson.util.MaskingClassLoader.loadClass(MaskingClassLoader.java:70) - waiting to lock <…> (a hudson.util.MaskingClassLoader) at java.lang.ClassLoader.loadClass(ClassLoader.java:411) - locked <…> (a hudson.ClassicPluginStrategy$DependencyClassLoader) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at jenkins.util.AntClassLoader.findBaseClass(AntClassLoader.java:1398) at jenkins.util.AntClassLoader.loadClass(AntClassLoader.java:1075) - locked <…> (a hudson.ClassicPluginStrategy$AntClassLoader2) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at hudson.util.XStream2$AssociatedConverterImpl.findConverter(XStream2.java:318) at hudson.util.XStream2$AssociatedConverterImpl.canConvert(XStream2.java:357) at com.thoughtworks.xstream.core.DefaultConverterLookup.lookupConverterForType(DefaultConverterLookup.java:59) - locked <…> (a com.thoughtworks.xstream.core.DefaultConverterLookup) at com.thoughtworks.xstream.XStream$1.lookupConverterForType(XStream.java:498) at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:56) at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:50) at com.thoughtworks.xstream.core.TreeUnmarshaller.start(TreeUnmarshaller.java:134) at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.unmarshal(AbstractTreeMarshallingStrategy.java:32) at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1189) at hudson.util.XStream2.unmarshal(XStream2.java:114) at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:1173) at com.thoughtworks.xstream.XStream.fromXML(XStream.java:1044) at com.thoughtworks.xstream.XStream.fromXML(XStream.java:1035) at … were blocked on one thread waiting for a lower-level lock: at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:390) - waiting to lock <…> (a org.eclipse.jetty.webapp.WebAppClassLoader) at java.lang.ClassLoader.loadClass(ClassLoader.java:411) - locked <…> (a hudson.util.MaskingClassLoader) at hudson.util.MaskingClassLoader.loadClass(MaskingClassLoader.java:75) - locked <…> (a hudson.util.MaskingClassLoader) at java.lang.ClassLoader.loadClass(ClassLoader.java:411) - locked <…> (a hudson.ClassicPluginStrategy$DependencyClassLoader) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at jenkins.util.AntClassLoader.findBaseClass(AntClassLoader.java:1398) at jenkins.util.AntClassLoader.loadClass(AntClassLoader.java:1075) - locked <…> (a hudson.ClassicPluginStrategy$AntClassLoader2) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at … It is clearly wrong for MaskingClassLoader to be adding its own synchronization here, especially when the only apparent reason for the synchronized statements in this case was to guard access to some rarely-written lists. I will propose a patch. Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.