[JIRA] (JENKINS-38903) Split the Exceptions handling for node provision and adding a node to Jenkins in NodeProvisioner

[pjano...@redhat.com (JIRA)]

Title: Message Title

Pavel Janoušek created an issue   Jenkins / JENKINS-38903 Split the Exceptions handling for node provision and adding a node to Jenkins in NodeProvisioner Issue Type: Improvement Assignee: Pavel Janoušek Components: core Created: 2016/Oct/11 2:43 PM Priority: Minor Reporter: Pavel Janoušek Current implementation of NodeProvisioner.update() handles an exception from node provisioning and adding a node to Jenkins in the one block where it isn't clear from which step an Exception was thrown - it can create a confusion for ex. Provisioned slave " + f.displayName + " failed to launch in handling ExecutionException is very confusing because the mentioned provisioned slave doesn't exist, it could never exist etc. I'd propose to split this to two separate try/catch blocks and adjust the error messages a bit: First part: Node node = f.future.get(); for (CloudProvisioningListener cl : CloudProvisioningListener.all()) { cl.onComplete(f, node); } should catch and handle InterruptedException, ExecutionException, Error and Throwable. Send part: jenkins.addNode(node); LOGGER.log(Level.INFO, "{0} provisioning successfully completed. " + "We have now {1,number,integer} computer(s)", new Object[]{f.displayName, jenkins.getComputers().length}); should catch and handle IOException, Error and Throwable. In addition the first part should handle the new type of Exception AbortException which has the unified meaning through the Jenkins - we need to signalize a situation when a provision process of a new node failed; during the provision process we know about this failure, we recovered from it and we need to report that situation to NodeProvisioner. In NodeProvisioner we shouldn't make any action because handling and recovering is a responsibility of the reported in the place it was thrown. Proposed change should be fully backward compatible. TO-DO: When we introduce this change in the core first, we can adjust exception throwing from cloud provider plugins. Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.