[JIRA] (JENKINS-38920) JPI plugin Manifest lacks Plugin-Class attribute when Gradle project was previously cleaned

[piotr.skowro...@gmail.com (JIRA)]

Title: Message Title

Piotr Skowronek created an issue   Jenkins / JENKINS-38920 JPI plugin Manifest lacks Plugin-Class attribute when Gradle project was previously cleaned Issue Type: Bug Assignee: Daniel Spilker Components: gradle-jpi-plugin Created: 2016/Oct/12 8:49 AM Environment: Gradle version: 2.8 Gradle-jpi-plugin version: 0.18.1 JDK: java 7 OS: OSX El Capitan and Linux Ubuntu Priority: Major Reporter: Piotr Skowronek JPI plugin Manifest lacks Plugin-Class attribute when Gradle project was previously cleaned. To reproduce: 1. have a basic gradle project with gradle-jpi-plugin that creates some jenkins plugin 2. run: ./gradlew clean 3. run: ./gradlew clean jpi - the resulting hpi plugin contains "faulty" Manifest w/o Plugin-Class attribute 4. run: ./gradlew clean jpi - the resulting hpi plugin contains Manifest with Plugin-Class attribute The problem lies in JpiPlugin.groovy#configureJpi (line with: project.afterEvaluate): project.tasks.findByName(LifecycleBasePlugin.ASSEMBLE_TASK_NAME).dependsOn(jpi) project.afterEvaluate { <--- jpi.archiveName = "${jpiExtension.shortName}.${jpiExtension.fileExtension}" jpi.extension = jpiExtension.fileExtension jpi.manifest.attributes(attributesToMap(new JpiManifest(project).mainAttributes)) <-- } This piece runs the code that collects attributes for Manifest just after "evaluation" aka "configuration" phase, i.e. when sources are not even built yet or the folder 'classes' is old (as it originates from previous build, like in #4 - clean is done after evaluation/configuration). Of course some attributes are being acquired by scanning generated classes, for example the problematic Plugin-Class attribute is produced only when hudson.Plugin exists and this file appears in classes folder as a result of the assemble task (created by PluginSubtypeMarker extending javax.annotation.processing.AbstractProcessor). I had to use the following workaround in my gradle file to ensure the Plugin-Class attribute is in place regardless of the state of the project: task workaround << { project.jpi.manifest.attributes(org.jenkinsci.gradle.plugins.jpi.JpiManifest.attributesToMap(new org.jenkinsci.gradle.plugins.jpi.JpiManifest(project).mainAttributes)) } project.tasks.findByName(org.jenkinsci.gradle.plugins.jpi.Jpi.TASK_NAME).dependsOn(workaround) Apparently this issue was introduced in JENKINS-31426 Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.