[JIRA] (JENKINS-15808) CVS plugin 2.7 breaks Gerrit Trigger (v2.5.2 and 2.6.0) configuration

Tue, 27 Nov 2012 16:09:47 -0800

I've done some additional testing (see procedure below). I can (unfortunately) reproduce it. CVS plugin 2.0 (the first one after 1.6) is when this behavior begins to happen.

I was suprised as well. I upgraded to 1.489 from 1.488 and also upgraded 3 plugins (CVS, Git, and Translations) and this started happening. Git and Translations seemed like the obvious suspects.

The config page form has an event listener on submit registered by buildFormTree at line 857 in hudson-behavior.js. That function seems to marshall the form data into JSON. It does have error handling, but maybe it can't alert because it's in the submit process already or something? I put an alert in the success state and it didn't pop up either.

The invalid JSON blob that appears in the failed request body ('init') is set in buildFormTree on line 863.

This isn't a huge problem for me as long as the included version of CVS doesn't change.

I'll keep digging.

Andy

///// test procedure (on os x 10.7.5) /////////
///////////////////////////////////////////////

// compile latest master build (Jenkins ver. 1.492-SNAPSHOT - a8d9397)
MAVEN_OPTS="-Xmx512m -XX:MaxPermSize=128m" mvn -Plight-test clean install
rm -rf /tmp/jenkins_test
mkdir -p /tmp/jenkins_test
// run compiled build
JENKINS_HOME=/tmp/jenkins_test java -jar ./war/target/jenkins.war
place job config in JENKINS_HOME/jobs/gerrit_trigger_test/config.xml
reload from disk
install gerrit trigger plugin (2.6.0, included Jenkins Git 1.1.26)
restart (ctrl-c and relaunch)
try configuring job (edit pink field in screenshot) and saving... works
update cvs plugin to 2.7
restart
try configuring job and saving... fails
disable cvs plugin
restart
try configuring job and saving... fails
downgrade to 1.6 - still disabled
restart
try configuring job and saving... fails
// unexpected... caching going on?
enable cvs 1.6 plugin
restart
try configuring job and saving... works
disable cvs plugin 1.6
restart
try configuring job and saving... fails
// again... strange...
re-enable cvs plugin 1.6
restart
try configuring job and saving... works

/////// CVS Version testing ///////////
downgrade to 1.6; restart
try configuring... works
install 2.0; restart
try configuring... fails
downgrade to 1.6 (unpin 2.0); restart
try configuring... works

////// job's config.xml /////////////////
/////////////////////////////////////////
<?xml version='1.0' encoding='UTF-8'?>
<project>
<actions/>
<description></description>
<keepDependencies>false</keepDependencies>
<properties/>
<scm class="hudson.plugins.git.GitSCM" plugin="[email protected]">
<configVersion>2</configVersion>
<userRemoteConfigs>
<hudson.plugins.git.UserRemoteConfig>
<name></name>
<refspec></refspec>
<url>ssh://GERRIT_SERVER:29418/chef-internal.git</url>
</hudson.plugins.git.UserRemoteConfig>
</userRemoteConfigs>
<branches>
<hudson.plugins.git.BranchSpec>
<name>**</name>
</hudson.plugins.git.BranchSpec>
</branches>
<disableSubmodules>false</disableSubmodules>
<recursiveSubmodules>false</recursiveSubmodules>
<doGenerateSubmoduleConfigurations>false</doGenerateSubmoduleConfigurations>
<authorOrCommitter>false</authorOrCommitter>
<clean>false</clean>
<wipeOutWorkspace>false</wipeOutWorkspace>
<pruneBranches>false</pruneBranches>
<remotePoll>false</remotePoll>
<ignoreNotifyCommit>false</ignoreNotifyCommit>
<useShallowClone>false</useShallowClone>
<buildChooser class="hudson.plugins.git.util.DefaultBuildChooser"/>
<gitTool>Default</gitTool>
<submoduleCfg class="list"/>
<relativeTargetDir></relativeTargetDir>
<reference></reference>
<excludedRegions></excludedRegions>
<excludedUsers></excludedUsers>
<gitConfigName></gitConfigName>
<gitConfigEmail></gitConfigEmail>
<skipTag>false</skipTag>
<includedRegions></includedRegions>
<scmName></scmName>
</scm>
<canRoam>true</canRoam>
<disabled>false</disabled>
<blockBuildWhenDownstreamBuilding>false</blockBuildWhenDownstreamBuilding>
<blockBuildWhenUpstreamBuilding>false</blockBuildWhenUpstreamBuilding>
<triggers class="vector">
<com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger plugin="[email protected]">
<spec></spec>
<gerritProjects>
<com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject>
<compareType>PLAIN</compareType>
<pattern>chef-internal</pattern>
<branches>
<com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Branch>
<compareType>ANT</compareType>
<pattern>**</pattern>
</com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Branch>
</branches>
</com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject>
</gerritProjects>
<silentMode>false</silentMode>
<escapeQuotes>true</escapeQuotes>
<buildStartMessage></buildStartMessage>
<buildFailureMessage></buildFailureMessage>
<buildSuccessfulMessage></buildSuccessfulMessage>
<buildUnstableMessage></buildUnstableMessage>
<buildNotBuiltMessage></buildNotBuiltMessage>
<buildUnsuccessfulFilepath></buildUnsuccessfulFilepath>
<customUrl></customUrl>
<triggerOnEvents>
<com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.events.PluginPatchsetCreatedEvent/>
</triggerOnEvents>
<dynamicTriggerConfiguration>false</dynamicTriggerConfiguration>
<triggerConfigURL></triggerConfigURL>
<triggerInformationAction/>
</com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger>
</triggers>
<concurrentBuild>false</concurrentBuild>
<builders/>
<publishers/>
<buildWrappers/>
/////////////////////////////////////////
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to