[JIRA] (JENKINS-39799) Nasty compilation failure when invalid build condition names used

[andrew.ba...@gmail.com (JIRA)]

Title: Message Title

Andrew Bayer created an issue   Jenkins / JENKINS-39799 Nasty compilation failure when invalid build condition names used Issue Type: Bug Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2016/Nov/16 11:22 PM Environment: pipeline-model-definition 0.5 Priority: Critical Reporter: Andrew Bayer For a post section like this: post { archive '**/*.hpi' junit '**/*.xml' } ...you get an error like this: BUG! exception in phase 'canonicalization' in source unit 'WorkflowScript' unexpected NullpointerException at org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1058) at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:591) at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:569) at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:546) at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:298) at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:268) at groovy.lang.GroovyShell.parseClass(GroovyShell.java:688) at groovy.lang.GroovyShell.parse(GroovyShell.java:700) at org.jenkinsci.plugins.workflow.cps.CpsGroovyShell.reparse(CpsGroovyShell.java:67) at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.parseScript(CpsFlowExecution.java:411) at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.start(CpsFlowExecution.java:374) at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:220) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:410) Caused by: java.lang.NullPointerException at org.jenkinsci.plugins.structs.SymbolLookup$Key.hashCode(SymbolLookup.java:144) at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936) at org.jenkinsci.plugins.structs.SymbolLookup.find(SymbolLookup.java:47) at org.jenkinsci.plugins.structs.SymbolLookup$find$0.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:133) at org.jenkinsci.plugins.pipeline.modeldefinition.validator.ModelValidatorImpl.validateElement(ModelValidatorImpl.groovy:146) at org.jenkinsci.plugins.pipeline.modeldefinition.ast.ModelASTBuildCondition.validate(ModelASTBuildCondition.java:27) at org.jenkinsci.plugins.pipeline.modeldefinition.ast.ModelASTBuildConditionsContainer.validate(ModelASTBuildConditionsContainer.java:40) at org.jenkinsci.plugins.pipeline.modeldefinition.ast.ModelASTPostBuild.validate(ModelASTPostBuild.java:31) at org.jenkinsci.plugins.pipeline.modeldefinition.ast.ModelASTPipelineDef.validate(ModelASTPipelineDef.java:72) at org.jenkinsci.plugins.pipeline.modeldefinition.ast.ModelASTPipelineDef$validate.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) at org.jenkinsci.plugins.pipeline.modeldefinition.parser.ModelParser.parse(ModelParser.groovy:207) at org.jenkinsci.plugins.pipeline.modeldefinition.parser.ModelParser$parse.callCurrent(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:52) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:154) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:166) at org.jenkinsci.plugins.pipeline.modeldefinition.parser.ModelParser.parse(ModelParser.groovy:108) at org.jenkinsci.plugins.pipeline.modeldefinition.parser.GroovyShellDecoratorImpl$1.call(GroovyShellDecoratorImpl.java:38) at org.codehaus.groovy.control.CompilationUnit.applyToPrimaryClassNodes(CompilationUnit.java:1053) ... 13 more We should be putting all SymbolLookup.get().find(...) calls in try/catch blocks and handling them more elegantly. Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.