[JIRA] (JENKINS-36121) Github Branch Source plugin trips api rate limit

[ja...@britecore.com (JIRA)]

Title: Message Title

Jacob Foster commented on JENKINS-36121   Re: Github Branch Source plugin trips api rate limit Hello. I work for a large organization that also ran into this problem. We ended up forking the plugin and adding the caching back in. It has worked great for us! https://github.com/IntuitiveWebSolutions/github-branch-source-plugin diff --git a/src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java b/src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java index 7838600..41a23b5 100644 --- a/src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java +++ b/src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java @@ -35,6 +35,7 @@ import com.cloudbees.plugins.credentials.domains.DomainRequirement; import com.cloudbees.plugins.credentials.domains.URIRequirementBuilder; import com.google.common.hash.Hashing; +import com.squareup.okhttp.Cache; import com.squareup.okhttp.OkHttpClient; import com.squareup.okhttp.OkUrlFactory; import hudson.Util; @@ -53,6 +54,7 @@ import org.apache.commons.lang.StringUtils; import org.jenkinsci.plugins.gitclient.GitClient; import org.jenkinsci.plugins.github.config.GitHubServerConfig; +import org.jenkinsci.plugins.github.internal.GitHubClientCacheOps; import org.kohsuke.github.GitHub; import org.kohsuke.github.GitHubBuilder; import org.kohsuke.github.RateLimitHandler; @@ -60,6 +62,7 @@ import static org.apache.commons.lang3.StringUtils.trimToEmpty; import static org.jenkinsci.plugins.github.config.GitHubServerConfig.GITHUB_URL; +import static org.jenkinsci.plugins.github.internal.GitHubClientCacheOps.toCacheDir; /** * Utilities that could perhaps be moved into {@code github-api}. @@ -83,6 +86,7 @@ } public static @Nonnull GitHub connect(@CheckForNull String apiUri, @CheckForNull StandardCredentials credentials) throws IOException { + GitHubServerConfig config = new GitHubServerConfig(credentials!=null ? credentials.getId(): null); String apiUrl = Util.fixEmptyAndTrim(apiUri); String host; try { @@ -97,6 +101,11 @@ gb.withRateLimitHandler(CUSTOMIZED); OkHttpClient client = new OkHttpClient().setProxy(getProxy(host)); + client.setCache(GitHubClientCacheOps.toCacheDir().apply(config)); + if (config.getClientCacheSize() > 0) { + Cache cache = toCacheDir().apply(config); + client.setCache(cache); + } gb.withConnector(new OkHttpConnector(new OkUrlFactory(client))); Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.