[JIRA] (JENKINS-35367) EMail-Ext Extended Pipeline Support - Templates

[da...@vanlaatum.id.au (JIRA)]

Title: Message Title

David van Laatum commented on JENKINS-35367   Re: EMail-Ext Extended Pipeline Support - Templates not exactly the best of examples eg the recipient providers could be passed directly to emailext rather than going through emailextrecipients. It also replicates much of the features of emailext // Append Culprits when the build is not successfull if (currentBuild.result != "SUCCESS") { to << emailextrecipients([[$class: 'CulpritsRecipientProvider']]) } is redundant as CulpritsRecipientProvider only adds culprits to the list if the build failed. It also doesn't handle the body throwing an exception In theory this is better (untested) def call(body) { // evaluate the body block, and collect configuration into the object def config = [:] body.resolveStrategy = Closure.DELEGATE_FIRST body.delegate = config try { body() } catch(e) { currentBuild.result = "FAILURE"; throw e; } finally { def subject = config.subject ? config.subject : "${env.JOB_NAME} - Build #${env.BUILD_NUMBER} - ${currentBuild.result}!" def content = '${JELLY_SCRIPT,template="static-analysis"}' // Attach buildlog when the build is not successfull def attachLog = (config.attachLog != null) ? config.attachLog : (currentBuild.result != "SUCCESS") // Send email emailext(body: content, mimeType: 'text/html', replyTo: '$DEFAULT_REPLYTO', subject: subject, to: config.emailRecipients, attachLog: attachLog, recipientProviders: [[$class: 'CulpritsRecipientProvider'], [$class: 'RequesterRecipientProvider']]) } } Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.