[JIRA] (JENKINS-38974) Comment Added event crashes with NullPointerException

[d...@djc.id.au (JIRA)]

Title: Message Title

Dan C commented on JENKINS-38974   Re: Comment Added event crashes with NullPointerException The problem seems to be that <commentTextParameterMode> is missing from existing job definitions. It's also not filled in by the plugin when an XML job definition is saved (for example when using Jenkins Job Builder, which doesn't generate any of the *ParameterMode elements). When that option is missing from the job definition the getter is returning null which means that commentTextMode is null in this block: if (event instanceof CommentAdded) { String comment = ((CommentAdded)event).getComment(); if (comment != null) { commentTextMode.setOrCreateParameterValue(GERRIT_EVENT_COMMENT_TEXT, parameters, comment, ParameterMode.PlainMode.TEXT, escapeQuotes); } } I see that in commit e94a36e0 there is some special handling for changeSubjectParameterMode, when it was added, to ensure that the default is filled in to the job definition. I guess a similar thing should have been done for commentTextParameterMode. Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.