[JIRA] (JENKINS-40454) P4Groovy does not support commas

[email protected] (JIRA) Wed, 14 Dec 2016 11:00:13 -0800

Title: Message Title

Pat Lewis created an issue

Issue Type:	Bug
Assignee:	Unassigned
Components:	p4-plugin
Created:	2016/Dec/14 6:59 PM
Environment:	P4 Plugin version 1.4.10 Jenkins version 1.651.2
Priority:	Major
Reporter:	Pat Lewis

The P4Groovy run method takes two string parameters: the command, and the arguments in a comma separated string, according to this presentation. Because the arguments are separated by commas, they can't support any commas anywhere in the command string.

Here's an example of where this is seen:

 
                                                                String previous_p4_changelist = "340295"
String current_p4_changelist = "340313"
def changes = perforce.run("changes", "//...@${previous_p4_changelist},${current_p4_changelist}, -s, submitted")

which I expected to show up in the console logs as

 
                                                                ... p4 changes //...@340295,340313 -s submitted

However, it actually showed up as

 
                                                                ... p4 changes //...@340295 340313 -s submitted

with a space in between the changelists instead of the necessary comma. As a result, the output I got from the command was incorrect.

I tried this workaround:

 
                                                                String previous_p4_changelist = "340295"
String current_p4_changelist = "340313"
def changes = perforce.run("changes", "//...@${previous_p4_changelist}\\,${current_p4_changelist}, -s, submitted")

But all that did was change the command to this:

 
                                                                ... p4 changes //...@340295\ 340313 -s submitted

I can use the classic shell script step to do these commands instead, but I was really hoping to use P4Groovy as it's a much cleaner solution. Is there any other kind of workaround for this?

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-40454) P4Groovy does not support commas

Reply via email to