[JIRA] (JENKINS-41187) [Declarative Pipeline] Stage "when" should have "stage" condition

[email protected] (JIRA) Wed, 18 Jan 2017 16:25:31 -0800

Title: Message Title

Patrick Wolf commented on

I don't like this syntax formatting.

When I see this :

 
                                                                stage ('Incremental Build') {
        when {
            not { stage 'Full Build' }
        }
    }
 
                                                            

I read it as when this Stage is not "Full Build". My first reaction is that is always true.

If we want to say it is dependent in someway then we need to make that relationship explicit. When stage "Full Build is not what? Not skipped, not run, not stable? That isn't clear.

Right now the use case described is easily done as shown. To me that is much more clear than the alternative. We can explore having some stage conditions but they need to be clear.

Maybe something like:

 
                                                                stage ('Incremental Build') {
        when {
             stage 'Full Build'  == SKIPPED
        }
    }
 
                                                            

 
                                                                stage ('Incremental Build') {
        when {
             stage 'Full Build'  == SUCCESS
        }
    }
 
                                                            

 
                                                                stage ('Incremental Build') {
        when {
             stage 'Full Build'  != UNSTABLE
        }
    }
 
                                                            

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-41187) [Declarative Pipeline] Stage "when" should have "stage" condition

Reply via email to