[JIRA] (JENKINS-40652) origin pr builds not treated as trusted

[3a835...@opayq.com (JIRA)]

Title: Message Title

marc young commented on JENKINS-40652   Re: origin pr builds not treated as trusted It's definitely a bug. I built the latest github-branch-source-plugin (2.0.1-beta-2) and all dependencies. I inserted logger statements inside the getTrustedRevision as: PullRequestSCMHead head = (PullRequestSCMHead) revision.getHead(); listener.getLogger().format("head source owner: " + head.getSourceOwner() + "%n"); listener.getLogger().format("head target repo owner: " + head.getTargetRepo().getOwner() + "%n"); listener.getLogger().format("collaboratorNames: " + collaboratorNames + "%n"); listener.getLogger().format("collaboratorNames empty: " + collaboratorNames.isEmpty() + "%n"); if (fork && collaboratorNames == null) { and during a build of a PR the output is: Connecting to https://api.github.com using myoung34/****** head source owner: _redactedowner_ head target repo owner: GHUser@2e80c396[login=_redactedowner_,location=Nashville, TN,blog=http://www._redactedowner_.com,email=<null>,name=_redactedowner_,company=<null>,followers=0,following=0,url="" collaboratorNames: [...snip..., myoung34, ...snip...] collaboratorNames empty: false Loading trusted files from base branch master at 784081c38d601c3602e76ba10394e8839333e22b rather than 90f516ebf3af5d9b2abfc6e8e6b2699a73b2ca3f Even though I'm a collaborator it's still saying that it's untrusted. The if condition is not being hit during this time, so it's not re-checking. I'm making some bugfixes now and hopefully the upstream owners will accept them when finished. Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.