[JIRA] (JENKINS-41518) Environment variable names not checked for validity during JSON -> Jenkinsfile resulting in invalid syntax

[kzan...@cloudbees.com (JIRA)]

Title: Message Title

Keith Zantow created an issue   Jenkins / JENKINS-41518 Environment variable names not checked for validity during JSON -> Jenkinsfile resulting in invalid syntax Issue Type: Bug Assignee: Andrew Bayer Components: pipeline-model-definition-plugin Created: 2017/Jan/27 3:45 PM Priority: Minor Reporter: Keith Zantow The environment variable name should be valid Java (well, Groovy) identifier, it should be validated such as not generating invalid Jenkinsfiles. This JSON: { "pipeline": { "agent": { "type": "none", "arguments": [] }, "stages": [ { "name": "s", "branches": [ { "name": "default", "steps": [ { "name": "echo", "arguments": [ { "key": "message", "value": { "isLiteral": true, "value": "m" } } ] } ] } ] } ], "environment": [ { "key": "S PACE", "value": { "isLiteral": true, "value": "" } }, { "key": "", "value": { "isLiteral": true, "value": "" } } ] } } Results in this invalid Jenkinsfile: pipeline { agent none stages { stage('s') { steps { echo('m') } } } environment { S PACE = '' = '' } } Add Comment   This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.