[JIRA] (JENKINS-50268) Preexisting pods contribute towards instanceCap

[jut...@hiya.com (JIRA)]

Title: Message Title

Jake Utley commented on JENKINS-50268   Re: Preexisting pods contribute towards instanceCap I see what you're saying. Our KubernetesCloud config looks like this: <clouds> <org.csanchez.jenkins.plugins.kubernetes.KubernetesCloud plugin="kubernetes@1.2.1"> <name>kubernetes</name> <templates/> <serverUrl>controller</serverUrl> <skipTlsVerify>false</skipTlsVerify> <namespace>jenkins-ci-stg</namespace> <jenkinsUrl>http://<<REDACTED>></jenkinsUrl> <containerCap>0</containerCap> <retentionTimeout>5</retentionTimeout> <connectTimeout>0</connectTimeout> <readTimeout>0</readTimeout> <maxRequestsPerHost>32</maxRequestsPerHost> </org.csanchez.jenkins.plugins.kubernetes.KubernetesCloud> </clouds> But if we do a "Reload from disk", then this gets added: <labels class="com.google.common.collect.ImmutableMap"> <entry> <string>jenkins</string> <string>slave</string> </entry> </labels> So the behavior does follow your description. However, I don't think that the plugin should have to depend on a reload to get into the proper state. In our case, we try to minimize our dependence on a persistent Jenkins configuration. We handle all our configuration in Groovy scripts that run at initialization time. In the case of our Kubernetes cloud, we have a script that looks like this: def jenkins = Jenkins.getInstance() def kubernetesCloud = new KubernetesCloud('kubernetes') kubernetesCloud.setServerUrl('controller') kubernetesCloud.setSkipTlsVerify(false) kubernetesCloud.setNamespace('jenkins-ci-stg') kubernetesCloud.setJenkinsUrl('<<REDACTED>>') kubernetesCloud.setContainerCapStr('0') jenkins.clouds.replace(kubernetesCloud) jenkins.save() This means that every time we start up, we get a fresh cloud, and the code you linked is not running.   This may be a bit of a unique usage, but the cloud should still start up with all its "defaults" in place. Perhaps the code in readResolve() that sets the defaults should be pulled into its own method, and then be called from both readResolve and the constructor? Add Comment   This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.