[JIRA] (JENKINS-50745) RHEL7's vncserver script is not compatible with the free list

[ubellava...@atq.qc.ca (JIRA)]

Title: Message Title

Ugo Bellavance created an issue   Jenkins / JENKINS-50745 RHEL7's vncserver script is not compatible with the free list Issue Type: Bug Assignee: Dimitri Tenenbaum Components: vncviewer-plugin Created: 2018-04-11 17:32 Environment: RHEL7, Jenkins 2.30 and 2.66, latest version of the plugin Priority: Major Reporter: Ugo Bellavance The behavior of the /bin/vncserver script has changed in RHEL7: When it checks for a display to start VNC on, the code has changed:   On RHEL6, when it finds that the first display in the free list is used, it dies On RHEL7, when it finds that the first display in the free list is used, it starts looking at display :1, bypassing the free list. Here's the original code on RHEL6: Find display number. if ((@ARGV > 0) && ($ARGV[0] =~ /^:(\d+)$/)) { $displayNumber = $1; shift(@ARGV); if (!&CheckDisplayNumber($displayNumber)) { die "A VNC server is already running as :$displayNumber\n"; # warn "A VNC server is already running as :$displayNumber\n"; # $displayNumber = &GetDisplayNumber(); } } elsif ((@ARGV > 0) && ($ARGV[0] !~ /^-/) && ($ARGV[0] !~ /^\+/)) { &Usage(); } else { $displayNumber = &GetDisplayNumber(); }   Here is what we did to get it to work correctly: Find display number. if ((@ARGV > 0) && ($ARGV[0] =~ /^:(\d+)$/)) { $displayNumber = $1; shift(@ARGV); if (!&CheckDisplayNumber($displayNumber)) { die "A VNC server is already running as :$displayNumber\n"; # warn "A VNC server is already running as :$displayNumber\n"; # $displayNumber = &GetDisplayNumber(); } } elsif ((@ARGV > 0) && ($ARGV[0] !~ /^-/) && ($ARGV[0] !~ /^\+/)) { &Usage(); } else { $displayNumber = &GetDisplayNumber(); }   Here's the equivalent code for RHEL6: if ((@ARGV > 0) && ($ARGV[0] =~ /^:(\d+)$/)) { $displayNumber = $1; shift(@ARGV); if (!&CheckDisplayNumber($displayNumber)) { die "A VNC server is already running as :$displayNumber\n"; } } elsif ((@ARGV > 0) && ($ARGV[0] !~ /^-/) && ($ARGV[0] !~ /^\+/)) { &Usage(); } else { $displayNumber = &GetDisplayNumber(); }   Add Comment   This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.