[JIRA] (JENKINS-50742) Detail view for pipelines on Bitbucket: "Opens branch in a new window" incorrectly goes to BB pull request builder

[kshu...@cloudbees.com (JIRA)]

Title: Message Title

Karl Shultz commented on JENKINS-50742   Re: Detail view for pipelines on Bitbucket: "Opens branch in a new window" incorrectly goes to BB pull request builder Here's what I've found. I bounced out to the Classic UI and clicked this link. It goes to the same, incorrect, PR builder.: So, we know this isn't really a Blue Ocean bug, because it's broken in classic as well. Now determined to find where this was coming from, I started grep'ing around in my Jenkins. In jobs/the-bitbucket-multibranch-job/branches/master/config.xml, there's an <actions> section. That looks like this: <actions> <com.cloudbees.jenkins.plugins.bitbucket.BitbucketLink plugin="cloudbees-bitbucket-branch-source@2.2.9"> <iconClassName>icon-bitbucket-branch</iconClassName> <url>https://bitbucket.beescloud.com/projects/FEB/repos/jenkins-49409/compare/commits?sourceBranch=refs%2Fheads%2Fmaster</url> </com.cloudbees.jenkins.plugins.bitbucket.BitbucketLink> <jenkins.scm.api.metadata.ObjectMetadataAction plugin="scm-api@2.2.2"> <objectUrl>https://bitbucket.beescloud.com/projects/FEB/repos/jenkins-49409/compare/commits?sourceBranch=refs%2Fheads%2Fmaster</objectUrl> </jenkins.scm.api.metadata.ObjectMetadataAction> <jenkins.scm.api.metadata.PrimaryInstanceMetadataAction plugin="scm-api@2.2.2"/> </actions> Those are the URLs which the links are taking me to, and they're wrong. So what's generating them? I wonder if it's this line in BitbucketSCMSource.java. It looks like this: template = UriTemplate .fromTemplate(getServerUrl() + SERVER_REPO_TEMPLATE + "/compare/commits{?sourceBranch}") Let's construct that by hand: 1. getServerUrl() presumably returns https://bitbucket.beescloud.com, since that's the server I set up. 2. SERVER_REPO_TEMPLATE is "/projects{/owner}/repos{/repo}", and that will resolve to {{projects/FEB/repos/jenkins-49409 3. /compare/commits 4. {?sourceBranch} is likely to resolve to refs/heads/master, just going on what I see in the console output for the checkout: git fetch --no-tags --progress https://github.beescloud.com/dev1/another-blank-repo.git +refs/heads/master:refs/remotes/origin/master 4. This gives us https://bitbucket.beescloud.com/ projects/FEB/repos/jenkins-49409 /compare/commits ?sourceBranch=refs/heads/master Add Comment   This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.