[JIRA] (JENKINS-50783) Support file based comments

[alon.bar...@gmail.com (JIRA)]

Title: Message Title

Alon Bar-Lev created an issue   Jenkins / JENKINS-50783 Support file based comments Issue Type: Improvement Assignee: lucamilanesio Components: gerrit-code-review-plugin Created: 2018-04-13 06:51 Priority: Major Reporter: Alon Bar-Lev Hi, It would be super great to be able to submit a file based (given file + lineno) comments and not only change comments. This will enable to make use of gerrit as frontend for managing warnings/errors of build, static code analysis (such as sonar or style) etc... As far as I imagine there can be two ways to perform this: 1. The simple - have an optional array of [ {file, lineno, comment} ] provided to the current API. 2. The cool - use a transaction syntax such as: Unable to find source-code formatter for language: groovy. Available languages are: actionscript, html, java, _javascript_, none, sql, xhtml, xml withGerritReview() { gerritAddComment("file1", 12, "bla bla") gerritAddComment("file2", 44, "bla bla sdf") gerritSetFlag("Code-Review", "+1") } Please also keep in mind parallel work. I could not understand how the magic of triggering is working due to lack of documentation, however, if a parallel job is invoked it should share the context/state of the parent job so that the parallel job can also add its information, two options here as well: 1. The simple - parallel job has its own comments, share is only the change information, can be given as standard job parameters. 2. The super-cool - the parallel job, if called within transaction context will be able to append to the existing transaction, share the change information + the state of transaction. Thank you for working on this, I am looking forward to be able to switch. Alon Add Comment   This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.