[JIRA] (JENKINS-51485) Warnings Plugin MSBuildParser does not handle hyphen or underscore in category

[johnmc...@gmail.com (JIRA)]

Title: Message Title

John Case created an issue   Jenkins / JENKINS-51485 Warnings Plugin MSBuildParser does not handle hyphen or underscore in category Issue Type: Bug Assignee: Ulli Hafner Components: warnings-plugin Created: 2018-05-22 15:34 Priority: Minor Reporter: John Case The following output (from [sass-lint|https://github.com/sasstools/sass-lint)] is not properly handled by the MSBuild parser:   dist/search-list.component.scss(41,17): warning shorthand-values : Property `margin` should be written more concisely as `5px 0 0` instead of `5px 0 0 0`   After fiddling around with it, I was able to figure out that it is failing on the category value "shorthand-values" Currently, the regex only expects letters and numbers in that string, it does not match on hyphens. I think the regex should be expanded to handle hyphens (and underscores would be good too.) The change should be simple enough.  Just modify the regex:   private static final String MS_BUILD_WARNING_PATTERN = "(?:^(?:.*)Command line warning ([A-Za-z0-9]+):\\s*(.*)\\s*\\[(.*)\\])|" + ANT_TASK + "(?:(?:\\s*\\d+>)?(?:(?:(?:(.*)\\((\\d*)(?:,(\\d+))?.*\\)|.*LINK)\\s*:|(.*):)\\s*([A-z-_]*\\s?(?:[Nn]ote|[Ii]nfo|[Ww]arning|(?:fatal\\s*)?[Ee]rror))\\s*:?\\s*([A-Za-z0-9]+)\\s*:\\s(?:\\s*([A-Za-z0-9.]+)\\s*:)?\\s*(.*?)(?: \\[([^\\]]*)[/\\\\][^\\]\\\\]+\\])?" + "|(.*)\\s*:.*error\\s*(LNK[0-9]+):\\s*(.*)))$"; with the following:     private static final String MS_BUILD_WARNING_PATTERN = "(?:^(?:.*)Command line warning ([A-Za-z0-9]+):\\s*(.*)\\s*\\[(.*)\\])|" + ANT_TASK + "(?:(?:\\s*\\d+>)?(?:(?:(?:(.*)\\((\\d*)(?:,(\\d+))?.*\\)|.*LINK)\\s*:|(.*):)\\s*([A-z-_]*\\s?(?:[Nn]ote|[Ii]nfo|[Ww]arning|(?:fatal\\s*)?[Ee]rror))\\s*:?\\s*([A-Za-z0-9\\-_]+)\\s*:\\s(?:\\s*([A-Za-z0-9.]+)\\s*:)?\\s*(.*?)(?: \\[([^\\]]*)[/\\\\][^\\]\\\\]+\\])?" + "|(.*)\\s*:.*error\\s*(LNK[0-9]+):\\s*(.*)))$"; I'd be happy to make a pull request in the github repo but it would take me a bit to get the tooling on my workstation to write a test.   Add Comment   This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.