[JIRA] (JENKINS-50783) Support file based comments

[email protected] (JIRA) Sun, 21 Oct 2018 23:03:11 -0700

Title: Message Title

Alon Bar-Lev commented on

One minor comment I wanted to add to github but it seems to be dead.

Maybe I do not understand the logic...

The default label cannot be verified as it will impact the previous settings, for example:

 
                                                                gerritComment label: CI-Static, score:1, message: 'Static analysis was passed'
gerritComment path:'path/to/file', line: 10, message: 'invalid syntax'

Or:

 
                                                                gerritComment score:1, message: 'ok'
gerritComment path:'path/to/file', line: 10, message: 'invalid syntax'

Or even:

 
                                                                gerritComment score:1, message: 'ok'
gerritComment message: 'I have more to say'

In all cases the verified label will be modified by the last gerritComment invocation which is not expected.

Options:

Have null as default label, this allows differentiate between intentional and non intentional.
Split the gerritComment into two commands, one to control the commit and one to control the file based comments, however even in this situation adding plain messages should be handled somehow, so back to (1).

Thanks!

Add Comment

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-50783) Support file based comments

Reply via email to