[JIRA] (JENKINS-54559) Build result regression since pipeline-maven 3.5.15 for failing tests (UNSTABLE)

[f.mod...@gmx.net (JIRA)]

Title: Message Title

Falko Modler created an issue   Jenkins / JENKINS-54559 Build result regression since pipeline-maven 3.5.15 for failing tests (UNSTABLE) Issue Type: Improvement Assignee: Alvaro Lobato Components: pipeline-maven-plugin Created: 2018-11-09 16:59 Environment: Jenkins ver. 2.138.2 pipeline-maven 3.5.15 Priority: Critical Reporter: Falko Modler The removal of this block is causing a (temporary) inconsistent overall build result because archiver.perform() used to set currentBuild.result in 3.5.14 (see also here) but now (due to the removal) the result is not set anymore. This now leads to other plugins picking up the wrong result (SUCCESS) when being used in post pipeline blocks. We, for instance, explicitely call step([$class: 'StashNotifier']) in cleanup which before 3.5.15 sent the correct status to BitBucket PRs but now with 3.5.15 the PRs always receive SUCCESS/OK even though there are test failures. And of course if you evaluate currentBuild.result directly (like we also do to send messages via Rocket.Chat), you also see the wrong result. The final pipeline build result is correct in these cases (UNSTABLE) but you just cannot retrieve it anymore from within the pipeline while it is still running. I consider this a severe breaking change. What puzzles me is that the very same commit that removed the invokation of archiver.perform() also remove this note (further down): // TODO: Once JENKINS-43995 lands, update this to set the step status instead of the entire build. Judging from it's status, JENKINS-43995 has not "landed" yet!   Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.