[JIRA] (JENKINS-55485) Declarative pipeline, lock() in stage aoptions is executed before when clause

[daniel.pa...@gmail.com (JIRA)]

Title: Message Title

D Pasto created an issue   Jenkins / JENKINS-55485 Declarative pipeline, lock() in stage aoptions is executed before when clause Issue Type: Bug Assignee: Unassigned Components: lockable-resources-plugin Created: 2019-01-09 14:48 Priority: Minor Reporter: D Pasto In a a declarative pipeline i have a stage grouping several other stages and need to hold a lock for the duration of the group.  I see I can add lock() to the options of the group and it works fine in that scenario.  However the group also has a When clause so I can turn that group off with a job parameter.   The problem is that when the "when" evaluates false so the stage will be skipped, it wait for the lock anyway.  If the stage will be skipped for any reason, we should not block on the lock.   My pipeline looks like: — pipeline { agent none stages {       stage ('Build') {      }       stage('Deploy-and-Test') { // Group Stage Deploy and test the Build - lock the deployment VM so we don't step on other runs           when {                _expression_ {                     "${params.Deploy}" == "true"                }               beforeAgent true           }           options {                lock(quantity: 1, resource: "${params.DeployAgent}", variable: 'myDeployAgent')           }           agent none           stages { ...}      }}}   When I run it withthe param to disable the stage I see: — [Pipeline] stage[Pipeline] { (Deploy-and-Test)[Pipeline] lockTrying to acquire lock on [DeploymentVM_Win] Lock acquired on [DeploymentVM_Win][Pipeline] {Stage "Deploy-and-Test" skipped due to when conditional — Since the stage is being skipped there is no point in holding the lock, but it the lock is already allocated, this will block anyway.  The lock() should be processed after the decision whether to execute the stage. Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.