[JIRA] (JENKINS-56063) git-plugin fails to expand variables in refspec on initial clone

[plros...@gmail.com (JIRA)]

Title: Message Title

Pavel Roskin created an issue   Jenkins / JENKINS-56063 git-plugin fails to expand variables in refspec on initial clone Issue Type: Bug Assignee: Mark Waite Attachments: git-clone-config.xml Components: git-plugin Created: 2019-02-08 22:23 Environment: Jenkins 2.150.2 Git plugin 4.0.0-rc Labels: git-plugin variables expansion Priority: Major Reporter: Pavel Roskin Git plugin fails to expand variables in the refspec setting. A sure way to trigger the bug is to enable both "Honor refspec on initial clone" and "Wipe out repository & force clone". The config is attached. Here's an excerpt from the log to the top-level job:   > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10 > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10 > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10 Cleaning workspace > git rev-parse --verify HEAD # timeout=10 No valid HEAD. Skipping the resetting > git clean -fdx # timeout=10 Pruning obsolete local branches Fetching upstream changes from http://stash/scm/rob/testrepository.git > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master6 --prune # timeout=10 Note that ${BUILD_ID} is not expanded in the first commit, but is expanded at the end where branch specifier is being used.   Remove "Wipe out repository & force clone", and the variable is being expanded now.   > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master9 --prune # timeout=10 > git rev-parse refs/remotes/origin/master9^{commit} # timeout=10 > git rev-parse refs/remotes/origin/refs/heads/master9^{commit} # timeout=10   It may seem a trivial issue with ${BUILD_ID}, but it's actually a big problem when I try pulling ${sourceCommitHash} with stash-pull-request-builder. That's why I consider it a major bug. It prevents me from using the correct commit received from Stash REST API and makes me use a suboptimal solution that involves a race condition. I believe git-plugin should always expand variables in the refspec setting on its own, without relying on the shell.   Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.