[JIRA] (JENKINS-55961) Nodejs plugin installs wrong platform package when using parallel pipeline

[email protected] (JIRA) Tue, 05 Mar 2019 03:45:10 -0800

Title: Message Title

I had the same issue and I solved it by adding different NodeJS installers in my configuration. It doesn't have to use different node versions, just different labels for the tool.

 
                                                                stage('Linux') {
    agent { label nodeLinux }
    steps {
        nodejs(nodeJSInstallationName: nodejsInstallation + '-linux') {
            sh 'yarn install'
        }
    }
}
stage('Win') {
    agent { label nodeWin }
    steps {
        nodejs(nodeJSInstallationName: nodejsInstallation + '-windows') {
            bat 'yarn install'
        }
    }
}
stage('MacOS') {
    agent { label nodeMac }
    steps {
        nodejs(nodeJSInstallationName: nodejsInstallation + '-macos') {
            sh 'yarn install'
        }
    }
}
 
                                                            

The NodeJSInstaller sets `this.platform` on the object itself and then calls a different method to compute the URL. That is not thread safe, so any other node installing at the same, will get use wrong platform. The NodeJSInstaller is used by InstallerTranslator (linked below) on multiple nodes simultaneously.

https://github.com/jenkinsci/nodejs-plugin/blob/master/src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java#L127

Notice how the semaphore used in InstallerTranslator is per node & per tool. That means the tool can install at most once at a time on a specific node. However, that doesn't prevent the same tool instance from installing on different nodes simultaneously.

https://github.com/jenkinsci/jenkins/blob/22aa2e6e766074d11249893e3f35e0b99e20d3d0/core/src/main/java/hudson/tools/InstallerTranslator.java#L72

Add Comment

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.

[JIRA] (JENKINS-55961) Nodejs plugin installs wrong platform package when using parallel pipeline

Reply via email to