[JIRA] (JENKINS-55726) GitHub can incorrectly flag PRs as passing checks if multiple jobs run against the same repository

[j3p...@hotmail.com (JIRA)]

Title: Message Title

Jon-Paul Sullivan commented on JENKINS-55726   Re: GitHub can incorrectly flag PRs as passing checks if multiple jobs run against the same repository Related to JENKINS-37100 and JENKINS-36574 - I think the latter may be the genesis for the current situation, which may have been a fix by Jesse Glick? I read through those bugs and can definitely see why the code is as it currently is, but I think an improvement can be made to satisfy both the current use case and also improve the situation where multiple Jenkins jobs are reporting to the single repository. I saw this mentioned but no discussion as to why it was ultimately not followed, so if there are issues then please do explain. The prime requirements for blocking merges is that there is a single string that any PR presents to GitHub so the repository settings can indicate the status of that context must be success prior to merge. This is currently set to "continuous-integration/jenkins/pr-merge".   public String getDefaultContext(TaskListener listener) { if (head instanceof PullRequestSCMHead) { if (((PullRequestSCMHead) head).isMerge()) { return "continuous-integration/jenkins/pr-merge"; } else { return "continuous-integration/jenkins/pr-head"; } } else { return "continuous-integration/jenkins/branch"; } }   The issue is that every Jenkins job returns that same context. In the case of a Multibranch configuration using GitHub, we will have a job whose name is [<folder>/]*<job>/<branch> where <branch> is either a branch or a special branch representing a Pull Request. The branch string changes each time a new branch or pull request is created, and this makes it unsuitable to be used as a merge gate for GitHub.  I would state that the enclosing job name is perfectly viable to use as a status context though, as that is unchanging across multiple Pull Requests. So the above code would become something like:   public String getDefaultContext(TaskListener listener) { if (head instanceof PullRequestSCMHead) { if (((PullRequestSCMHead) head).isMerge()) { return "continuous-integration/jenkins/" + job.getParent() + "/pr-merge"; } else { return "continuous-integration/jenkins/" + job.getParent() + "/pr-head"; } } else { return "continuous-integration/jenkins/" + job.getParent() + "/branch"; } }   Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.