[JIRA] (JENKINS-57492) Isolate errors during SCM scanning

[bitwise...@gmail.com (JIRA)]

Title: Message Title

Liam Newman updated an issue   Jenkins / JENKINS-57492 Isolate errors during SCM scanning Change By: Liam Newman In https://issues.jenkins-ci.org/browse/JENKINS-56996 we isolated errors in PR scanning to make them not crash the scan overall.  We should isolate other errors as well. Wow. I did some digging on this and it is not particularly easy. I'd love to be able to simply catch and swallow some error locally, but if we do that it may result in jobs being deleted (or marked for deletion) simply because there was an error while reading them. I looked pretty carefully and I didn't see a way to address this safely in a small/local change. The core problem is that the code that controls how child items are created and maintained is spread across several other plugins, including folders, scm-api and branch-api. My thought is that we'll need to add a no-op {{ preserve(String itemName) }} method to {{[ SCMHeadObserver |https://github . com/jenkinsci/scm-api-plugin/blob/6a044fe60143278ed26f8d91b0ec1cee116617d6/src/main/java/jenkins/scm/api/SCMHeadObserver.java#L43]}}. Then we can wire through an implementation in {{[ MultiBranchProject.SCMHeadObserverImpl |https://github . com/jenkinsci/branch-api-plugin/blob/ed229d8e1392645c99e5686b8bd652a14ec87f4a/src/main/java/jenkins/branch/MultiBranchProject.java#L1948]}}. Finally, we'd expose that in github-branch-source for the {{ GitHubSCMSource }} to call when an error occurs. I suppose it would okay for PRs specifically to simply be deleted on {{ FileNotFoundException }} specifically, but not great behavior.     Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199353.1557946897000.2225.1557946980315%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.