[JIRA] (JENKINS-57649) Lockable resource plugin should not lock a resources when it is offline

[jimkli...@gmail.com (JIRA)]

Title: Message Title

Jim Klimov edited a comment on JENKINS-57649   Re: Lockable resource plugin should not lock a resources when it is offline While there is a good purpose in this request, I believe it is destined to be an offtopic/WontFix here. The plugin manages the generic concept of resources, does not even care if they are physically represented or not (you can use it to e.g. throttle a maximum amount of jobs holding a limited amount of tokens at a time). That said, you *can* use the Groovy script option of implementing *your* use-case dependent logic and eveelintually eventually return a `true` or `false` about whether a proposed resource is eligible for your job. The plugin calls such script in a loop for each resource ( your script should test that it matches the label _expression_ you asked for? want then ) and makes a list of items with a "true" verdict, to offer one (or first?) of those to be locked by a job. I am not sure if it levels the load on physical resources (giving first vs random eligible). As part of this logic you can do anything; for some of our tests in the house, we have indeed a script that probes SSH availability of a remote VM we'd be setting up with our product as part of such logic, so broken VMs are not offered to jobs. A trimmed-down example would be: {code} public static boolean serverListening(String host, int port) {     Socket s = null;     try     {         s = new Socket(host, port);         return true;     }     catch (Exception e)     {         return false;     }     finally     {         if(s != null)             try {s.close();}             catch(Exception e){}     } } //println "Inspecting the resource to lock for requested CONTROLLER='" + CONTROLLER + "' (looking at resourceName='" + resourceName + "' resourceDescription='" + resourceDescription + "' resourceLabels='" + resourceLabels + "')" // + "' in build number " + build.getNumber() + if ( serverListening(resourceName, 22) ) {     println "ACCEPTED '" + resourceName + "'"     return true; } println "Resource '" + resourceName + "' is not suitable for this job" return false; // Tested resource is not appropriate for this build {code} With this, we do however miss another ability: to see quickly which resources were last diagnosed dead. Arguably, this is out of LockableResources' scope as well however (rather belongs in zabbix or similar monitoring tool, or maybe a custom job to inspect the list of resources and "lock" broken ones by a specific holder, and unlock fixed ones... maybe along the lines of this https://stackoverflow.com/a/52744986/4715872 fine example). But it would be helpful to have such a status anyway and have it all displayed in the same list of Available/Reserved/Locked/+Broken+ Jenkins resources :) Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199580.1558641515000.24414.1560166080144%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.