[JIRA] (JENKINS-58068) Races / corruption on revision.txt in pipeline-parallel

[andreas.ringlstet...@gmail.com (JIRA)]

Title: Message Title

Andreas Ringlstetter created an issue   Jenkins / JENKINS-58068 Races / corruption on revision.txt in pipeline-parallel Issue Type: Bug Assignee: Ivan Fernandez Calvo Components: subversion-plugin Created: 2019-06-18 12:44 Priority: Major Reporter: Andreas Ringlstetter In the scope of JENKINS-39968, the subversion plugin suffers from additional races due to the dependency on the "revision.txt" file as part of the checkout and change log computation process. Unsynchronized access to "revision.txt" causes `SubversionChangeLogBuilder ` to fail spuriously, as the file may be written to concurrently by other running checkout processes. The final "revision.txt" eventually reaches a stable state where it only contains the revision of the last "checkout" step, but in the process `SubversionChangeLogBuilder` has failed to record changes repeatedly (bailout with "No revision found for ....") and the "build.xml" is corrupted and contains fragments like the following: <org.jenkinsci.plugins.workflow.steps.scm.MultiSCMRevisionState plugin="workflow-scm-step@2.9"> <revisionStates> <entry> <string>svn http://redacted/trunk</string> <hudson.scm.SVNRevisionState plugin="subversion@2.12.1"> <revisions> <entry> <string>ed/trunk</string> <long>16122</long> </entry> <entry> <string>svn http://redacted/trunk</string> <long>12362</long> </entry> </revisions> </hudson.scm.SVNRevisionState> </entry> </revisionStates> </org.jenkinsci.plugins.workflow.steps.scm.MultiSCMRevisionState> In summary: Unsafe reads from "revision.txt" which contains data from parallel checkout processes Lost writes to "revision.txt" from previous checkout steps in the same build, with unstable results While producing "revision.txt" as a side product of the build process may be desired to keep as a side effect, using it internally means state between `SubversionSCM` instances in the same build is shared in an unsafe way. Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200092.1560861846000.2424.1560861900341%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.