[JIRA] (JENKINS-58177) Leading - in workspace directory names mangled in multibranch pipeline

[ro...@pickl.eu (JIRA)]

Title: Message Title

Roman Pickl created an issue   Jenkins / JENKINS-58177 Leading - in workspace directory names mangled in multibranch pipeline Issue Type: Bug Assignee: Unassigned Components: branch-api-plugin Created: 2019-06-25 05:54 Environment: jenkins-war:2.176.1 branch-api-plugin: 2.5.2 Priority: Minor Reporter: Roman Pickl Apparently, some of our workspaces for specific branch names are mangled in a way that the directories start with a "-" (or multiple!). This would require some special handling in scripts and we would like to avoid that.   There also have been some discussions about this special case in the now obsolete implementation in JENKINS-38706: https://issues.jenkins-ci.org/browse/JENKINS-38706?focusedCommentId=272733&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-272733 https://issues.jenkins-ci.org/browse/JENKINS-38706?focusedCommentId=324422&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-324422 https://issues.jenkins-ci.org/browse/JENKINS-38706?focusedCommentId=345815&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-345815 https://issues.jenkins-ci.org/browse/JENKINS-38706?focusedCommentId=348257&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-348257 I had a look and it seems to happen here: https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/WorkspaceLocatorImpl.java#L193   It can be tested with this small java program:   import org.apache.commons.lang3.StringUtils; public class Test { public static void main(String args[]) { int MAX_LENGTH=32; String fullName= "JIRA-1054_rename_1234_to_abcdef_try2"; String mnemonic = mnemonicOf(fullName); String path = StringUtils.right(mnemonic, MAX_LENGTH); System.out.println(path); } private static String mnemonicOf(String name) { // Do not need the complexity of NameMangler here, since we uniquify as needed. return name.replaceAll("(%[0-9A-F]{2}|[^a-zA-Z0-9-_.])+", "_"); } } Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200228.1561442061000.7823.1561442100148%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.