[JIRA] (JENKINS-58362) CommandLauncher2Test.requireApproval failure due to two copies of SystemCommandLanguage

[jgl...@cloudbees.com (JIRA)]

Title: Message Title

Jesse Glick created an issue   Jenkins / JENKINS-58362 CommandLauncher2Test.requireApproval failure due to two copies of SystemCommandLanguage Issue Type: Bug Assignee: Jesse Glick Components: command-launcher-plugin, core, jenkins-test-harness Created: 2019-07-05 14:21 Labels: plugin-compat-tester regression lts-candidate Priority: Minor Reporter: Jesse Glick JENKINS-57528 included a bump to the detached script-security which should have been paired with a bump to the detached command-launcher. To reproduce, run mvn -f command-launcher-plugin test -Djenkins.version=2.176.1 -Dtest=CommandLauncher2Test\#requireApproval which passes; now bump its parent to 3.47 and include -Djenkins.version=2.176.2-rc28314.ce9ac38e8574 -Pconsume-incrementals which pulls in this backport by Oliver Gondža and you will get a failure: java.lang.AssertionError: expected:<org.jenkinsci.plugins.scriptsecurity.scripts.languages.SystemCommandLanguage@...> but was:<org.jenkinsci.plugins.command_launcher.SystemCommandLanguage@...> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at hudson.slaves.CommandLauncher2Test$1.evaluate(CommandLauncher2Test.java:119) Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200477.1562336462000.2390.1562336520437%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.