[JIRA] [copyartifact] (JENKINS-17606) Copy Artifact's fingerprinting creates second hudson.tasks.Fingerprinter_-FingerprintAction section with just the artifacts copied

Wed, 17 Apr 2013 11:09:42 -0700

Ok, this seems more tricky. The problem occurs when CopyArtifact is done in a job invoked in a non-blocking manner from the main job:

  (A) main job
   (B) |-> parametrized trigger action as Build step
    (C) |-> Copy Artifacts from job (A)



What I see in code is that FingerprintingCopyMethod:116 checks if there is FingerprintAction already for the Build or not and handles it fine:




FingerprintAction fa = r.getAction(FingerprintAction.class);
if (fa != null) fa.add(fingerprints);
else            r.getActions().add(new FingerprintAction(r, fingerprints));






On the other hand if CopyArtifact is called earlier for the Build, Fingerprinter task does not check if the FingerprintAction was present or not and adds the second instance (see Fingerprinter.java:136).



Is it correct approach just to mimic the CopyArtifact behavior and check for previously added FingerprintAction?
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to