[JIRA] (JENKINS-59152) Jenkins fails to properly abort "bat" step

[ma...@slonopotamus.org (JIRA)]

Title: Message Title

Marat Radchenko created an issue   Jenkins / JENKINS-59152 Jenkins fails to properly abort "bat" step Issue Type: Bug Assignee: Unassigned Components: core Created: 2019-08-30 16:04 Environment: Windows Jenkins 2.176.1 Priority: Major Reporter: Marat Radchenko Windows Jenkins 2.176.1 Create pipeline: node() { bat "ping 127.0.0.1 -n 100000" } Run pipeline Abort pipeline View build log Expected: pipeline aborts fast and without any issues Actual (66% reproducibility): It takes pipeline 20s to abort Build log contains "Click here to forcibly terminate running steps" and "After 20s process did not stop", indicating that Jenkins has issues with stopping the pipeline "Click here to forcibly terminate running steps" link is still visible even after the build has finished Issue analysis: There is a race condition between 2 minute timer in hudson.util.ProcessTree.WindowsOSProcess#killSoftly introduced for JENKINS-17116 and 20s timer in org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep.Execution#stop. It is possible for DurableTaskStep to pretend that step was cancelled while it fact process is still running. Because of this race condition, it is possible to trick Jenkins into thinking that build has finished while if fact there are still processes running in workspace and potentially locking files there (this happens to us in practice). org.jvnet.winp.WinProcess#sendCtrlC that is used in hudson.util.ProcessTree.WindowsOSProcess#killSoftly is NOT a proper way to terminate processes. Many apps do not interpret CTRL+C as a shutdown signal. (cmd.exe being the most important one here, because running bat in pipeline involved TWO cmd.exe - one running jenkins-wrapper.bat and second running jenkins-main.bat. Why you're not using TerminateProcess function from WinAPI? There's a race condition between gathering of process list in hudson.util.ProcessTree.Windows#Windows constructor and killing of the processes, during which build can produce new processes that will not be attempted to be killed. Usage of JENKINS_NODE_COOKIE to find what processes to kill is unreliable because 1) processes are free to alter their environment 2) CreateProcessA allows to pass custom environment variables 3) It has unpredictable order 4) It doesn't match Jenkins behavior on Linux Add Comment   This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201589.1567181048000.3341.1567181100131%40Atlassian.JIRA.