[JIRA] (JENKINS-59580) NPE in OSProcess#hasMatchingEnvVars on Windows

[ma...@slonopotamus.org (JIRA)]

Title: Message Title

Marat Radchenko created an issue   Jenkins / JENKINS-59580 NPE in OSProcess#hasMatchingEnvVars on Windows Issue Type: Bug Assignee: Unassigned Components: core Created: 2019-09-30 06:37 Environment: Windows, Jenkins Core master from GitHub Priority: Major Reporter: Marat Radchenko Reproducing code: OUTER: while (true) { for (OSProcess proc : ProcessTree.get()) { if (proc.hasMatchingEnvVars(Collections.singletonMap("foo", "bar"))) { break OUTER; } } } Analysis: 1. OSProcess#hasMatchingEnvVars assumes that OSProcess#getEnvironmentVariables never returns null (and its Javadoc says so). 2. There's a time frame between ProcessTree.get() and call to getEnvironmentVariables 3. If proccess exits during this timeframe, an exception is thrown by org.jvnet.winp.WinProcess#getEnvironmentVariables, propagated through WindowsOSProcess#getEnvironmentVariables2, then caught in WindowsOSProcess#getEnvironmentVariables 4. And finally, WindowsOSProcess#getEnvironmentVariables returns null, thus violating contract from superclass Javadoc. Add Comment   This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202220.1569825441000.7582.1569825480108%40Atlassian.JIRA.