[JIRA] (JENKINS-59503) Plugin does not save settings

[mrpedr...@gmail.com (JIRA)]

Title: Message Title

Pedro Pereira commented on JENKINS-59503   Re: Plugin does not save settings The reason for this to happen is because the parameter names defined in config.jelly do not match the ones expected by the java class. config.jelly: https://github.com/jenkinsci/rocketchatnotifier-plugin/blob/develop/src/main/resources/jenkins/plugins/rocketchatnotifier/RocketChatNotifier/config.jelly java class: https://github.com/jenkinsci/rocketchatnotifier-plugin/blob/05c758f75f583da6b124cfa803aa7e8907e0a995/src/main/java/jenkins/plugins/rocketchatnotifier/RocketChatNotifier.java If you inspect the fields and manually change the input names in the HTML to the ones expected by the java class, you will be able to save.  For example, in the config.jelly it states the parameter to notify on success is named rocketNotifySuccess, however, the java class expects the parameter to be called notifySuccess. Apart from this issue, there is also another issue when you try to save the configs when choosing to add a custom message: org.kohsuke.stapler.NoStaplerConstructorException: There's no @DataBoundConstructor on any constructor of boolean at org.kohsuke.stapler.ClassDescriptor.loadConstructorParamNames(ClassDescriptor.java:265) at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:765) at org.kohsuke.stapler.RequestImpl.access$200(RequestImpl.java:83) at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:678) Caused: java.lang.IllegalArgumentException: Failed to instantiate boolean from {"customMessage":""} at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:681) at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:478) at org.kohsuke.stapler.RequestImpl.injectSetters(RequestImpl.java:834) at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:784) at org.kohsuke.stapler.RequestImpl.access$200(RequestImpl.java:83) at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:678) Caused: java.lang.IllegalArgumentException: Failed to instantiate class jenkins.plugins.rocketchatnotifier.RocketChatNotifier from (...) However, even after changing these values to allow for the configs to be saved (without the custom message), the notification still didn't go out after the job started/failed/succeeded, which leds me to believe that could be another issue that's not related to this one. Hope this helps to debug the issue.   Add Comment   This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202124.1569316263000.4085.1572343140209%40Atlassian.JIRA.