[JIRA] (JENKINS-60368) Server Sent Events doesn't work with CORS

[sschlet (JIRA)]

Title: Message Title

Stefan Schletterer updated an issue   Jenkins / JENKINS-60368 Server Sent Events doesn't work with CORS Change By: Stefan Schletterer We use the CORS plugin to be able to access jenkins content from an HTML REST Client. To receive status updates on our dashboard we use the Jenkins SSE Gateway plugin with the _javascript_ client. {{The plugin doesn't use the CORS settings from the CORS plugin. So far we have forked the repo and hard coded cors like this in *src\main\java\org\jenkinsci\plugins\ssegateway\Endpoint.java*: }} {{public void doFilter(...)}}{{...}} {{String origin = httpServletRequest.getHeader("Origin");}} {{httpServletResponse.addHeader("Access-Control-Allow-Credentials", "true");}} {{httpServletResponse.setHeader("Access-Control-Allow-Origin", origin);}} {{httpServletResponse.setHeader("Access-Control-Allow-Methods", "POST, GET, OPTIONS, PUT, DELETE, HEAD");}} {{httpServletResponse.setHeader("Access-Control-Allow-Headers", "X-PINGOTHER, LAST-EVENT-ID, Origin, X-Requested-With, Content-Type, Accept");}}{{...}} {{But much better would be to get the cors settings from the plugin, if it is installed and enabled:}} cors=Jenkins.instance.pluginManager.plugins.find  it.getShortName()=='cors-filter'  {{corsClass=AccessControlsFilter.class}}{{resp.addHeader("Access-Control-Allow-Methods", getDescriptor().getAllowedMethods());}} ...   However, I dont know about the performance implications of querying the cors plugin on every request. Could you point me in the right direction so I can create a proper pull request?     Add Comment   This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203412.1575475245000.167.1575478740076%40Atlassian.JIRA.