[JIRA] (JENKINS-59300) p4-plugin sets client root to null with template workspaces

[hows...@gmail.com (JIRA)]

Title: Message Title

David Hows edited a comment on JENKINS-59300   Re: p4-plugin sets client root to null with template workspaces So, i've just been bitten hard by this in or Prod environment. I'm not by any means fluent in Java, but it looks like the issue is proximally caused by the line you mentioned, but actually caused because the deepClone() is actually not a deep clone, but rather a shallow clone. My understanding is that this would make all the subobjects references to the original and any changes would be reflected in both. Consider the call to deepClone() [here|[https://github.com/jenkinsci/p4-plugin/blob/master/src/main/java/org/jenkinsci/plugins/p4/workspace/Workspace.java#L165] ] it simply calls [clone()| [ https://docs.oracle.com/javase/7/docs/api/java/lang/Object.html]] which per Javadoc is a shallow copy.   Add Comment   This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201847.1568127629000.4204.1578438240421%40Atlassian.JIRA.