[JIRA] (JENKINS-60833) Plugin assumes password and http password are the same

[kunick...@gmail.com (JIRA)]

Title: Message Title

Adam Kunicki created an issue   Jenkins / JENKINS-60833 Plugin assumes password and http password are the same Issue Type: Bug Assignee: Luca Domenico Milanesio Components: gerrit-code-review-plugin Created: 2020-01-22 02:17 Environment: Jenkins 2.190.3 LTS Gerrit 3.0.3 LDAP login Priority: Critical Reporter: Adam Kunicki We are using LDAP login for our Gerrit instance. For REST calls (including repo cloning) you must generate an HTTP password that is different from the LDAP login. The gerrit-code-review-plugin currently assumes that these are the same. The client library used, does support setting them separately (https://github.com/uwolfer/gerrit-rest-java-client/blob/v0.8.15/src/main/java/com/urswolfer/gerrit/client/rest/GerritAuthData.java#L101) This is causing us to see the following in the gerrit logs: [2020-01-22 01:35:58,480] [HTTP-21816] WARN com.google.gerrit.httpd.auth.ldap.LdapLoginServlet : 'jenkins-ci' failed to sign in: Incorrect username or password This appears to coincide with posting comments, as we are not seeing any Verification status changes or comments from Jenkins using gerritReview or gerritComment. I've confirmed that using an http client the HTTP password (same as one in credentials id used for cloning) is sufficient. For example to set the Verified -1 label: POST to gerrit-server.com/a/changes/<change id>/revisions/<patchset number>/review This appears to be discussed in this issue and resolved in PR#70 Add Comment   This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204184.1579659425000.3542.1579659480210%40Atlassian.JIRA.